Prevent mandatory jobs from being added to the list of rejected jobs (bugfix) #1602
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When user de-selects jobs in the UI, they may de-select mandatory jobs.
These jobs, even if de-selected, will still be added to the list of jobs
to run later on, and will be executed.
Therefore, they should not be part of the rejected jobs list.
This problem does not happen when using the
match
feature.Resolved issues
While investigating #1557 , I found this other issue.
Documentation
Tests
Apart from the unit test being updated, I ran the following test:
Launch Checkbox using this launcher:
De-select every job and run the test.
Check the generated
submission.json
:manifest
) are executed (part ofresults
), and they are not in therejected-jobs
list.rejected-jobs
.