Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the installed package instead of from ubuntu-archive (BugFix) #640

Closed
wants to merge 1 commit into from

Conversation

os369510
Copy link

@os369510 os369510 commented Jul 26, 2023

…e instead of from ubuntu-archive (LP: #2027655)

Description

The current test case checks the recommended packages of ubuntu-desktop which is the version from ubuntu-archive.
However, we need to check the package we currently installed on the system.

Resolved issues

Fixes: the tool part from https://bugs.launchpad.net/stella/+bug/2027655

Documentation

Tests

Tested-by: [email protected]

@andychi117
Copy link
Contributor

Fix: https://bugs.launchpad.net/stella/+bug/2027655
Test:
Outcome: job passed
==============[ Running job 2 / 2. Estimated time left: 0:01:00 ]===============
---[ Check if Debian packages in Recommends of ubuntu-desktop are installed ]---
ID: com.canonical.certification::miscellanea/ubuntu-desktop-recommends
Category: com.canonical.plainbox::miscellanea
... 8< -------------------------------------------------------------------------
All packages in Recommends of ubuntu-desktop are installed.
------------------------------------------------------------------------- >8 ---
Outcome: job passed
Finalizing session that hasn't been submitted anywhere: checkbox-run-2023-07-26T07.15.20
==================================[ Results ]===================================
☑ : Collect information about installed software packages
☑ : Check if Debian packages in Recommends of ubuntu-desktop are installed
ubuntu@ubuntu:/usr/lib/checkbox-provider-base/bin$ apt policy ubuntu-desktop
ubuntu-desktop:
Installed: 1.481
Candidate: 1.481.1
Version table:
1.481.1 500
500 http://tw.archive.ubuntu.com/ubuntu jammy-updates/main amd64 Packages
*** 1.481 500
500 http://tw.archive.ubuntu.com/ubuntu jammy/main amd64 Packages
100 /var/lib/dpkg/status

Copy link
Collaborator

@pieqq pieqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this problem! Just one suggestion inline.

providers/base/bin/check-ubuntu-desktop-recommends.sh Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@0abe030). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             main    #640   +/-   ##
======================================
  Coverage        ?   2.50%           
======================================
  Files           ?     125           
  Lines           ?   13953           
  Branches        ?    2367           
======================================
  Hits            ?     350           
  Misses          ?   13546           
  Partials        ?      57           
Flag Coverage Δ
provider-base 2.49% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

[p/b/b/check-ubuntu-desktop-recommends.sh] (LP: #2027655)
@os369510 os369510 changed the title [p/b/b/check-ubuntu-desktop-recommends.sh] Check the installed packag… Check the installed package instead of from ubuntu-archive (bugfix) Oct 20, 2023
@os369510 os369510 changed the title Check the installed package instead of from ubuntu-archive (bugfix) Check the installed package instead of from ubuntu-archive (BugFix) Oct 20, 2023
@clairlin53 clairlin53 requested a review from pieqq October 27, 2023 06:01
Copy link
Collaborator

@pieqq pieqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@pieqq
Copy link
Collaborator

pieqq commented Nov 8, 2023

@os369510 can you sign your commits and resubmit? Please see our contrib doc about this: https://github.com/canonical/checkbox/blob/main/CONTRIBUTING.md#signed-commits-required

Then we'll be good to land this!

@kissiel
Copy link
Contributor

kissiel commented Jan 6, 2024

I've done the rebase in #914, so it may actually land quickly.
Let's close this one.

@kissiel kissiel closed this Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants