-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check the installed package instead of from ubuntu-archive (BugFix) #640
Conversation
Fix: https://bugs.launchpad.net/stella/+bug/2027655 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this problem! Just one suggestion inline.
Codecov Report
@@ Coverage Diff @@
## main #640 +/- ##
======================================
Coverage ? 2.50%
======================================
Files ? 125
Lines ? 13953
Branches ? 2367
======================================
Hits ? 350
Misses ? 13546
Partials ? 57
Flags with carried forward coverage won't be shown. Click here to find out more. |
[p/b/b/check-ubuntu-desktop-recommends.sh] (LP: #2027655)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
@os369510 can you sign your commits and resubmit? Please see our contrib doc about this: https://github.com/canonical/checkbox/blob/main/CONTRIBUTING.md#signed-commits-required Then we'll be good to land this! |
I've done the rebase in #914, so it may actually land quickly. |
…e instead of from ubuntu-archive (LP: #2027655)
Description
The current test case checks the recommended packages of ubuntu-desktop which is the version from ubuntu-archive.
However, we need to check the package we currently installed on the system.
Resolved issues
Fixes: the tool part from https://bugs.launchpad.net/stella/+bug/2027655
Documentation
Tests
Tested-by: [email protected]