Created using advanced configs (infra) #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor: new plugin to put todos in the docs
Hook25
force-pushed
the
advanced_config_tutorial
branch
from
696ca2d
to
f7162ef
Compare
diohe0311
previously approved these changes
Aug 2, 2023
pieqq
previously requested changes
Aug 4, 2023
There was a problem hiding this comment.
I still have a feeling that this is not a tutorial (we are not guiding the user through something in order to achieve something, we are just listing a lot of options from the launchers and explaining what's the use for them), and this is duplicating a lot of info that can be found elsewhere in the documentation. Some sections feel like a how-to, some are more like a reference document...
That said, I've added inline comments, but I think we need feedback from other people like @yphus or @kissiel, or people who have a better understanding of the documentation process.
mz2
reviewed
Dec 1, 2023
mz2
requested changes
Dec 1, 2023
Co-authored-by: Matias Piipari <[email protected]>
|
Added a few more changes:
|
tang-mm
changed the title
mz2
previously approved these changes
Jan 9, 2024
kissiel
approved these changes
Jan 9, 2024
LiaoU3
pushed a commit
to LiaoU3/checkbox
that referenced
this pull request
Mar 20, 2024
* Created using advanced configs Minor: new plugin to put todos in the docs * Fixed spelling * Minor: fixed typo * Implemented feedback from review * Apply suggestions from code review Co-authored-by: Matias Piipari <[email protected]> * update format in reference * add config inheritance to explanation * add auto-retry how-to guide * add ui verbosity how-to guide * rework tutorial * add syntax highlighting * add spelling check exception --------- Co-authored-by: tang-mm <[email protected]> Co-authored-by: Matias Piipari <[email protected]> Co-authored-by: MengT <[email protected]>
binli
pushed a commit
to binli/checkbox
that referenced
this pull request
Mar 22, 2024
* Created using advanced configs Minor: new plugin to put todos in the docs * Fixed spelling * Minor: fixed typo * Implemented feedback from review * Apply suggestions from code review Co-authored-by: Matias Piipari <[email protected]> * update format in reference * add config inheritance to explanation * add auto-retry how-to guide * add ui verbosity how-to guide * rework tutorial * add syntax highlighting * add spelling check exception --------- Co-authored-by: tang-mm <[email protected]> Co-authored-by: Matias Piipari <[email protected]> Co-authored-by: MengT <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This introduces several advanced topics for configurations like config inheritance and custom report and transport
Resolved issues
Resolves: https://warthogs.atlassian.net/browse/CHECKBOX-757
Documentation
N/A
Tests
N/A