Fix flake8 error #646
Merged
Fix flake8 error #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hook25
approved these changes
Jul 31, 2023
diohe0311
added a commit
that referenced
this pull request
Jul 31, 2023
This checks the type of variables via isinstance instead of type ==, allowing for inheritance and making tox happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Flake8 has been updated over the weekend: https://pypi.org/project/flake8/#history.
As a result, some scripts in providers/base failed the Flake8 test.
I'm not sure if specifying the flake version to run the tests is a good solution. So I changed those scripts under providers/base/bin/ to pass flake8 tests.
Resolved issues
Documentation
Tests
Create this PR see if provider-base could pass tox test in py38 env