Enforce coverage requirement and reporting via codecov #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hook25
changed the title
Codecov Report
@@ Coverage Diff @@
## main #672 +/- ##
=======================================
Coverage ? 31.46%
=======================================
Files ? 302
Lines ? 35156
Branches ? 6141
=======================================
Hits ? 11061
Misses ? 23572
Partials ? 523 |
|
The codecov message works :) the issue it is pointing at is due to the fact that he does not know how much coverage we have in main yet |
kissiel
reviewed
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This upgrades our coverage reporting by uploading to codecov.io. Using the features of said service, this also starts to enforce a patch based coverage requirement (for now just hardcoded at 80%).
Resolved issues
Resolves: https://warthogs.atlassian.net/browse/CHECKBOX-799
Documentation
This adds a new section to the contributing guide that explains how to get a local coverage report, why we want a coverage constraint and how we enforce it. This section also points to where the coverage constraint is specified and how it is reported io PRs (the pointer is there because in the future we may want to change the requirement, we don't want to have to update this file with the new one!)
Tests
N/A