Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the canary test plan #674

Merged
merged 3 commits into from
Aug 24, 2023
Merged

add the canary test plan #674

merged 3 commits into from
Aug 24, 2023

Conversation

kissiel
Copy link
Contributor

@kissiel kissiel commented Aug 21, 2023

Description

This test plan is meant to run on Checkbox versions that are candidates for a release. The jobs included here are explicitly listed so the same jobs are run in each session. Moreover, the jobs picked here are ones that on a stable device should all pass if the Checkbox stack is ok. In other words, failure to successfully run all the tests contained here should signify that there is a bug in the Checkbox code.

Resolved issues

Resolves CHECKBOX-795

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@c71db97). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 201ded1 differs from pull request most recent head 604108b. Consider uploading reports for the commit 604108b to get more accurate results

@@          Coverage Diff           @@
##             main    #674   +/-   ##
======================================
  Coverage        ?   1.95%           
======================================
  Files           ?     126           
  Lines           ?   14950           
  Branches        ?    2583           
======================================
  Hits            ?     292           
  Misses          ?   14595           
  Partials        ?      63           

Copy link
Collaborator

@pieqq pieqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test plan looks good. It covers:

  • normal jobs
  • template jobs
  • template jobs using the jinja2 engine
  • different kinds of reboot
  • suspend/resume
  • after-suspend jobs

It doesn't have any graphics-related job though; how about adding graphics/{index}_driver_version_{product_slug} (it's a before and after suspend job that spits out some driver info)? It would requires graphics_card resource job.

I also have a question inline.

Comment on lines 85 to 90
com.canonical.certification::power-management/warm-reboot
com.canonical.certification::power-management/warm-reboot
com.canonical.certification::power-management/post-warm-reboot
com.canonical.certification::power-management/cold-reboot
com.canonical.certification::power-management/cold-reboot
com.canonical.certification::power-management/post-cold-reboot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are power-management/warm-reboot and power-management/cold-reboot run twice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's my mistake stemming from the approach I took to generate the list. Removed in 604108b

@kissiel
Copy link
Contributor Author

kissiel commented Aug 22, 2023

It doesn't have any graphics-related job though; how about adding graphics/{index}_driver_version_{product_slug} (it's a before and after suspend job that spits out some driver info)? It would requires graphics_card resource job.

Great idea. So here goes your first addition compared to what we had previously for edge testing (as it used IoT TP, so no GPU stuff). Added in d30661e.

Copy link
Collaborator

@pieqq pieqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks!

@pieqq pieqq merged commit d055b89 into main Aug 24, 2023
7 checks passed
@pieqq pieqq deleted the add-canary-tp branch August 24, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants