add submission schema and tools to generate it (New) #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kissiel
changed the title
mz2
reviewed
Oct 19, 2023
mz2
requested changes
Oct 19, 2023
Hook25
requested changes
Nov 21, 2023
There was a problem hiding this comment.
Lets keep one way to do this: quicktype.
How was the schema.json file generated in this PR? Did we use genson or quicktype? If we used genson please double check that the result is the same. Also, the build_schema.py script should be updated to reflect this tool change (if we still need it)
|
I'll rerun the checks with submissions I used. |
|
The one in the PR is the genson one. |
|
Schema replaced, genson instructions dropped. Please review ASAP. |
Hook25
requested changes
Dec 1, 2023
Use node from nodesource, introduce a package.json + a lock.
Hook25
force-pushed
the
submission-json-schema
branch
from
8c710fd
to
024f359
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the schema of submission.json that's uploaded to C3 from Checkbox.
Alongside there's an instruction on how to generate that.
Resolved issues
Resolves: https://warthogs.atlassian.net/browse/CHECKBOX-927