Split arch and name action as the build repo (infra) #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And with that patch how many workers will we occupy when building *? |
|
1 (debs) + 2*4*3 (frontend) + 2*3 (runtime) = 31 (all self hosted runners, all jobs that are not intensive at all and can be swapped in and out frequently) |
|
I'd keep frontends together. They snap relatively fast, and provisioning the runner (installing snapcraft) can be slower than snapping everything together. |
|
ok good idea, I agree, I partially roll back the frontend change (keeping the QOL, that is very nice) |
kissiel
suggested changes
Oct 26, 2023
mz2
previously approved these changes
Oct 26, 2023
|
Let's not mess with that loop right now, the glob will match one snap. |
Minor: Spaces, nomenclature, moved comments Minor: bumped retries for build and upload Minor: clarified comment
Hook25
force-pushed
the
move_to_forked_action
branch
from
19b92cc
to
4e95087
Compare
kissiel
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Building multiple arches per matrix expansion leads the workflow to hang waiting for slower archs even if a build failed and makes us unable to re-run the build for a specific arch if it failed. With this modification each arch is built with its own command.
Minor: This also includes a new step that dumps the build URL, this makes it way easier to debug the build if anything goes wrong at runtime
Minor: A few name changes (prettier output for the action menu)
Resolved issues
The probability of a full build is hindered by the fact that every series either builds all arches or retries them all, this greatly increases the probability of retrying the individual arch because it goes from
P(arch_failure)to1-(1-P(arch_failure))**3Documentation
This improves the build readability by providing the URL where the build repo is allowing for further debugging if needed without searching this information in the log at runtime
Tests
Started the frontend workflow to see if it works at: https://github.com/canonical/checkbox/actions/runs/6652646495/job/18077062870