Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update the url to the stable PPA (Infra) #860

Closed
wants to merge 1 commit into from
Closed

update the url to the stable PPA (Infra) #860

wants to merge 1 commit into from

Conversation

kissiel
Copy link
Contributor

@kissiel kissiel commented Dec 1, 2023

Description

A follow up to the PPA switch. This time for an lxd profile used by metabox.

Tests

Tested by running metabox session.

@kissiel kissiel changed the title update the url to the stable PPA update the url to the stable PPA (Infra) Dec 1, 2023
fernando79513
fernando79513 approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@fernando79513 fernando79513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

yphus
yphus previously requested changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@yphus yphus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is no longer valid. Changes introduced by #866 make this patch obsolete.

Hook25
Hook25 approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still has to change as the current value is not valid

@kissiel kissiel dismissed yphus’s stale review December 12, 2023 15:56

factually incorrect

@kissiel
Copy link
Contributor Author

kissiel commented Jan 8, 2024

This got ultimately fixed in #859

@kissiel kissiel closed this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fernando79513 fernando79513 fernando79513 approved these changes

@Hook25 Hook25 Hook25 approved these changes

@yphus yphus yphus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kissiel @yphus @Hook25 @fernando79513