Enable multi interface testing in gateway_ping_test.py (New)
#998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kissiel
force-pushed
the
multi-if-ping-test-support
branch
from
7676ac8
to
051f7e7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #998 +/- ##
=======================================
Coverage 38.98% 38.99%
=======================================
Files 333 333
Lines 37045 37051 +6
Branches 6316 6318 +2
=======================================
+ Hits 14441 14447 +6
Misses 21976 21976
Partials 628 628
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kissiel
force-pushed
the
multi-if-ping-test-support
branch
from
051f7e7
to
7c2f183
Compare
Hook25
reviewed
Feb 19, 2024
LiaoU3
pushed a commit
to LiaoU3/checkbox
that referenced
this pull request
Mar 20, 2024
…ical#998) * enable multi-interface pinging on gateway-ping test script * add any-cable-interface ping job
binli
pushed a commit
to binli/checkbox
that referenced
this pull request
Mar 22, 2024
…ical#998) * enable multi-interface pinging on gateway-ping test script * add any-cable-interface ping job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR rearranges the code of
gateway_ping_test.pyto enable running the test on more than one interface. This is needed for SRU changes where we want the test to pass if any of the cable interfaces can ping the gateway.This PR also adds a new job that checks if the DUT can ping a gateway of any of its cable network interfaces, and replaces the job that try pinging with each of the interfaces with this one in the SRU test plan.
Resolved issues
Resolves: CHECKBOX-1243
Tests
Everything should be covered by the unit tests.
I've also tested it manually with multiple interface configurations