Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add name to jobs running in actions #29

Merged
merged 7 commits into from
Dec 7, 2023
Merged

Conversation

locnnil
Copy link
Contributor

@locnnil locnnil commented Dec 7, 2023

As mentioned, this PR adds names to the Workflow jobs to increase readability.

locnnil and others added 6 commits December 4, 2023 19:46
Add automated build on pull requests and commits on branch main.

Signed-off-by: Lincoln Wallace <[email protected]>
Added separation lines and comentaries to improve redability
Use output as snap name to don't leat hardcoded version or architecture.

Signed-off-by: Lincoln Wallace <[email protected]>
Verb tense corrections.

Co-authored-by: Farshid Tavakolizadeh <[email protected]>
Signed-off-by: Lincoln Wallace <[email protected]>
Adds name to workflow jobs to increase readability

Signed-off-by: Lincoln Wallace <[email protected]>
Copy link
Member

@farshidtz farshidtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition, but in this case, the comments become redundant since the steps are self-explanatory.

Now that the Jobs have a name, it can be used to self describe what the jobs does
So the commentaries are no longger need.

Signed-off-by: Lincoln Wallace <[email protected]>
@farshidtz farshidtz merged commit 7e78b48 into canonical:main Dec 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants