Use matter-snap-testing to handle log files #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor tests to use latest utils and new env packages
Enable goimports formatting
farshidtz
reviewed
Aug 6, 2024
farshidtz
requested changes
Aug 6, 2024
farshidtz
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes:
Remove log file writing and rather use functions from matter-snap-testing
Note
Requires canonical/matter-snap-testing#33 to be merged and a new release to be made. Then we can bump the version of matter-snap-testing ingo.mod.The automated testing by Github actions will fail until we do this.Testing Steps
All three tests are passing.