Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM64 build on native runner #80

Closed
wants to merge 11 commits into from
Closed

ARM64 build on native runner #80

wants to merge 11 commits into from

Conversation

jpm-canonical
Copy link
Contributor

Summary

Change workflow job for arm64 build to run on native arm64 runner, rather than emulated on amd64.

Testing Steps

Check if the CI job passes.

@jpm-canonical
Copy link
Contributor Author

image

Running on arm speeds it up enough that we could run the tests on arm too. Should we do that?

If we run the tests on both arm and amd, we can split this into two workflows. Will that be more or less maintainable?

@jpm-canonical
Copy link
Contributor Author

jpm-canonical commented Sep 2, 2024

Using separate workflows for AMD64 and ARM64. After removing the git-lfs requirement from the workflow both run successfully.

Screenshot from 2024-09-02 09-51-19
Screenshot from 2024-09-02 09-51-15

It looks like promotion of the snap fails on AMD64 when ARM64 does not have a revision in the source branch. Need to investigate this. Does a promote command promote all architectures?

Maybe better to use snap release: canonical/matter-pi-gpio-commander#84 (comment)

@farshidtz
Copy link
Member

Splitting this into two workflows results in a lot of replication. This should ideally be one workflow with a job matrix.

Yes, snapcraft promote promotes all builds from one channel to another. I don't think one can specify just one architecture. If using a job matrix for the build and tests, the promotion can happen in a separate job once the previous jobs finish and converge.

@jpm-canonical jpm-canonical deleted the ci-build-on-arm branch September 30, 2024 11:24
@jpm-canonical jpm-canonical restored the ci-build-on-arm branch September 30, 2024 11:25
@jpm-canonical jpm-canonical deleted the ci-build-on-arm branch September 30, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants