Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Add CLA check, Linting and security scanning #31

Merged
merged 6 commits into from
Sep 26, 2023
Merged

CI: Add CLA check, Linting and security scanning #31

merged 6 commits into from
Sep 26, 2023

Commits on Sep 25, 2023

  1. ci: add cla-check, lint and security scan workflows 

    This commit adds the following github workflows:

  - CLA check: Check if Canonical's Contributor License Agreement has
    been signed by the PR author(s).
  - Lint: Ensure fomatting changes using ``gofmt`` and run errcheck,
    unused, staticcheck linters using golangci-lint.
  - Security: Run Trivy vulnerability scanner to check for known
    vulnerabilities.

Co-authored-by: Cristovao Cordeiro <[email protected]>
    @rebornplusplus @cjdcordeiro
    rebornplusplus and cjdcordeiro committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    055f9eb View commit details
    Browse the repository at this point in the history

  2. refactor: format with go fmt ./...

    @rebornplusplus
    rebornplusplus committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    3dbf218 View commit details
    Browse the repository at this point in the history

  3. refactor: remove unused code 

    This commit removes unused code (variables, functions etc.) across the
codebase, with a few exceptions. Namely the unused functions from
``log.go`` in various packages are kept for future use. Additionally
the ``addDebugCommand`` function in `cmd/chisel/main.go` is kept too.
    @rebornplusplus
    rebornplusplus committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    98d8c25 View commit details
    Browse the repository at this point in the history

  4. refactor: remove deprecated (imported) packages 

    The ``io/ioutil`` package has been deprecated since Go 1.19. Usage of
this package have been removed appropriately.

The ``golang.org/x/crypto/ssh/terminal`` package has been deprecated and
moved to ``golang.org/x/term`` package. Usage have been updated likewise.
    @rebornplusplus
    rebornplusplus committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    22e8b8d View commit details
    Browse the repository at this point in the history

  5. refactor: always check errors

    @rebornplusplus
    rebornplusplus committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    8e05dc3 View commit details
    Browse the repository at this point in the history

  6. ci: configure linters 

    This commit adds a config file ``.golangci.yaml`` for the lint workflow.
It removes the previous arguments passed to golangci-lint in favor of
the new configuration file.
    @rebornplusplus
    rebornplusplus committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    04a90d7 View commit details
    Browse the repository at this point in the history