feat(alerting): detect flapping alerts #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sed-i
reviewed
Jul 9, 2024
| - name: AlertRules | ||
| rules: | ||
| - alert: AlertRulesFlapping | ||
| expr: changes(ALERTS_FOR_STATE{severity = "warning"}[1h]) > 5 |
There was a problem hiding this comment.
TIL!
Apparently there also ALERTS, but the value there is "1", whereas for ALERTS_FOR_STATE it's timestamp.
How did you find out this exists?
There was a problem hiding this comment.
ALERTS is not working with changes for some reason, when I found this out I google and find out about ALERTS_FOR_STATE it is internal metrics which is used to track alert state in between prometheus restarts. According to official docs
There was a problem hiding this comment.
Would we need to replicate the alert per severity?
|
Hi, during next two day I'm going to test this rule with inhibitions rules, so please do not merge I might be able to find some useful improvements |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
We are currently not providing any alert rules that would detect when an alert is transitioning to and from
pendingin a fast pace, which means we could potentially loose out on information from recurring intermittent errors.Solution
Detect whenever an alert is transitioning more than 5 times in the last hour.
Context
resolves #145
Testing Instructions
Upgrade Notes