Split bases #9
Merged
Split bases #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sed-i
requested review from
Abuelodelanada,
lucabello,
PietroPasotti,
dstathis and
simskij
as code owners
PietroPasotti
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
A 22.04-built charm fails on 20.04.
Solution
Split bases, so there's a 1:1 match between build-on and run-on.
Fixes #5.
FIxes #6.
Depends on:
Context
Even though charmhub doesn't display the full context correctly yet, if we upload two revisions for two different bases, juju will be able to pick the correct one.
charmcraft uploadshould be able to take several*.charmfiles at once charmcraft#1263 (comment)Note that our current CI does not support multiple *.charm files. Planning to do release manually for now.