Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functionality -> Feature #309

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Functionality -> Feature #309

merged 3 commits into from
Apr 9, 2024

Conversation

eaudetcobello
Copy link
Contributor

@eaudetcobello eaudetcobello commented Apr 8, 2024

Tried to separate code/docs changes but our git diff CI did not like that... "changes not in repository".

Note: not every instance of the word "functionality" is renamed in docs because "feature" would not be appropriate in those instances. Eg: "If [...] your cluster will return to normal functionality."

@eaudetcobello eaudetcobello requested a review from a team as a code owner April 8, 2024 18:23
@eaudetcobello eaudetcobello changed the title Functionality -> Feature in DOCS Functionality -> Feature Apr 8, 2024
Copy link
Contributor

github-actions bot commented Apr 8, 2024

Package Line Rate
github.com/canonical/k8s/api/v1 43%
github.com/canonical/k8s/cmd/k8s 29%
github.com/canonical/k8s/cmd/util 14%
github.com/canonical/k8s/pkg/client/dqlite 44%
github.com/canonical/k8s/pkg/component 10%
github.com/canonical/k8s/pkg/k8sd/controllers 63%
github.com/canonical/k8s/pkg/k8sd/database 48%
github.com/canonical/k8s/pkg/k8sd/pki 53%
github.com/canonical/k8s/pkg/k8sd/setup 75%
github.com/canonical/k8s/pkg/k8sd/types 82%
github.com/canonical/k8s/pkg/proxy 6%
github.com/canonical/k8s/pkg/snap 15%
github.com/canonical/k8s/pkg/snap/util 90%
github.com/canonical/k8s/pkg/utils 41%
github.com/canonical/k8s/pkg/utils/control 61%
github.com/canonical/k8s/pkg/utils/errors 100%
github.com/canonical/k8s/pkg/utils/k8s 71%
Summary 41% (2010 / 4850)

Copy link
Contributor

@louiseschmidtgen louiseschmidtgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, I don't see anything wrong with this, it's good to go!

@louiseschmidtgen louiseschmidtgen merged commit ff0360b into main Apr 9, 2024
16 checks passed
@louiseschmidtgen louiseschmidtgen deleted the KU-587 branch April 9, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants