Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use autoupdate/release-1.xx-strict branches for strict #411

Merged
merged 2 commits into from
May 8, 2024

Conversation

neoaggelos
Copy link
Contributor

Summary

Use autoupdate/release-1.xx-strict for strict release branches, to avoid having the auto promotion jobs failing due to branch protection rules

This also makes the strict branches fall in line with autoupdate/strict, to make it clear that these branches are not to be interacted with.

@neoaggelos neoaggelos requested a review from a team as a code owner May 8, 2024 07:06
Copy link
Contributor

github-actions bot commented May 8, 2024

Package Line Rate
github.com/canonical/k8s/api/v1 35%
github.com/canonical/k8s/cmd/k8s-apiserver-proxy 0%
github.com/canonical/k8s/cmd/k8s 37%
github.com/canonical/k8s/cmd/k8sd 0%
github.com/canonical/k8s/cmd 0%
github.com/canonical/k8s/cmd/util 15%
github.com/canonical/k8s/pkg/client/dqlite 48%
github.com/canonical/k8s/pkg/client/helm 5%
github.com/canonical/k8s/pkg/client/helm/mock 100%
github.com/canonical/k8s/pkg/client/kubernetes 69%
github.com/canonical/k8s/pkg/k8s/client 0%
github.com/canonical/k8s/pkg/k8s/client/mock 8%
github.com/canonical/k8s/pkg/k8sd/api 14%
github.com/canonical/k8s/pkg/k8sd/api/impl 0%
github.com/canonical/k8s/pkg/k8sd/app 11%
github.com/canonical/k8s/pkg/k8sd/controllers 45%
github.com/canonical/k8s/pkg/k8sd/database 48%
github.com/canonical/k8s/pkg/k8sd/database/util 0%
github.com/canonical/k8s/pkg/k8sd/features 4%
github.com/canonical/k8s/pkg/k8sd/pki 52%
github.com/canonical/k8s/pkg/k8sd/setup 77%
github.com/canonical/k8s/pkg/k8sd/types 78%
github.com/canonical/k8s/pkg/proxy 6%
github.com/canonical/k8s/pkg/snap/mock 85%
github.com/canonical/k8s/pkg/snap 17%
github.com/canonical/k8s/pkg/snap/util 90%
github.com/canonical/k8s/pkg/utils 60%
github.com/canonical/k8s/pkg/utils/control 100%
github.com/canonical/k8s/pkg/utils/errors 100%
github.com/canonical/k8s/pkg/utils/experimental/snapdconfig 12%
github.com/canonical/k8s/pkg/utils/node 0%
github.com/canonical/k8s/pkg/utils/shims 0%
Summary 37% (2551 / 6876)

@addyess
Copy link
Contributor

addyess commented May 8, 2024

Can you link to the failing auto update jobs? Is there anyway to adjust the branch-protection rules instead?

@neoaggelos
Copy link
Contributor Author

An example can be seen in https://github.com/canonical/k8s-snap/actions/runs/8986030620/job/24681222255#step:4:5, where the job currently succeeds precisely because of manually bypassing the branch protection rules.

Copy link
Contributor

@addyess addyess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE LGTM

@addyess addyess merged commit 532393b into main May 8, 2024
13 checks passed
@addyess addyess deleted the fix/autoupdate-strict branch May 8, 2024 16:58
neoaggelos added a commit that referenced this pull request May 9, 2024
* use autoupdate/release-1.xx-strict branches for strict

* adjust CI branches
neoaggelos added a commit that referenced this pull request May 9, 2024
* use autoupdate/release-1.xx-strict branches for strict

* adjust CI branches
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants