Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch COS Lite How-To to use the k8s-operator charm #872

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Switch COS Lite How-To to use the k8s-operator charm #872

merged 3 commits into from
Dec 9, 2024

Conversation

mateoflorido
Copy link
Member

Overview

Update the Integrating with COS Lite How-To guide to use the k8s-operator charm as the deployment substrate instead of the MicroK8s snap.

@mateoflorido mateoflorido requested a review from a team as a code owner December 6, 2024 01:49
bschimke95
bschimke95 approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, leave the final approval to @nhennigan

louiseschmidtgen
louiseschmidtgen reviewed Dec 6, 2024
View reviewed changes
Copy link
Contributor

@louiseschmidtgen louiseschmidtgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Mateo! Couple of small nits.

I can't highlight this in the review but can you fix line 12 as well please:
This document assumes that you have a controller with an installation of Canonical
Kubernetes.

nhennigan
nhennigan approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@nhennigan nhennigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit but otherwise LGTM. Once you answer amc94 question I think its good to merge.

@mateoflorido mateoflorido merged commit aabe445 into main Dec 9, 2024
6 checks passed
@mateoflorido mateoflorido deleted the KU-1145/cos-using-k8s branch December 9, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amc94 amc94 amc94 left review comments

@louiseschmidtgen louiseschmidtgen louiseschmidtgen left review comments

@nhennigan nhennigan nhennigan approved these changes

@bschimke95 bschimke95 bschimke95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mateoflorido @nhennigan @amc94 @louiseschmidtgen @bschimke95