-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure the CIS and DISA STIG hardening guides #890
Conversation
ktsakalozos
commented
Dec 11, 2024
- rename the CIS and DISA STIG hardening pages to assessments
- include the DISA STIG assessment report
- have the post-deployment hardening steps in one place
- CIS assessment page includes all the checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
most spell-checker errors seem unrelated but "unsecure" should probably be "insecure" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments; most are to myself and I'll address them in the DISA checker tool ASAP.
@ktsakalozos note that a couple of the footer links are either obsolete/not pointing to pages that exist [yet]
@bschimke95 correct, though unfortunately all 3 of those instances of "unsecure" are from text sourced verbatim from the upstream Findings defs (V-242451, V-242466, V-242467) I had noticed them when first implementing the checker and had a decent laugh (presume they're all written by the same DISA employee); but considering we'll be hosting these ourselves now, I'll have the tool update them so we don't look bad too. LE: re-reading the descriptions of each, I'll give the guy the benefit of the doubt and assume they're probably a typo for |
413a275
to
67fa0b4
Compare
fixed broken links and removed unneeded ones. Reverted changes to .wordlist - it should not be altered. Fixed index page to show CIS on navbar
Changes that were requested were reviewed and either implemented or marked won't do.
* Restructure the CIS and DISA STIG hardening guides * Fix spelling errors --------- Co-authored-by: Etienne Audet-Cobello <[email protected]> Co-authored-by: nhennigan <[email protected]>