Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure vm is finished booting before connecting to it via terminal #1064

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Jan 21, 2025

Done

  • Ensure vm is finished booting before connecting to it via terminal

Fixes #1063

QA

  1. Run the LXD-UI:
  2. Perform the following QA steps:
    • start / stop vms and from the instance terminal page.

@webteam-app
Copy link

Kxiru
Kxiru previously approved these changes Jan 21, 2025
Copy link
Contributor

@Kxiru Kxiru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :) Might wait for another perspective, also!

Copy link
Collaborator

@mas-who mas-who left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should change the empty state text for the state where the instance is booting. Maybe "Instance starting" for the heading and "Terminal will be ready once the instance booting is complete." for the message?

Screenshot from 2025-01-21 16-39-45

src/pages/instances/InstanceTerminal.tsx Show resolved Hide resolved
Copy link
Collaborator

@mas-who mas-who left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thanks for the fix!

@edlerd edlerd merged commit 4350da7 into canonical:main Jan 21, 2025
11 checks passed
@edlerd edlerd deleted the fix-instance-boot branch January 21, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starting a VM on the terminal page will immediately show you an error
4 participants