-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [WD-18264] CMS fields for storage pool source #1070
Conversation
6d79915
to
b87a423
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good progress, some comments on the code below.
b87a423
to
7e47745
Compare
7e47745
to
173b015
Compare
114dc76
to
fb81463
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is fully functional now, good progress. I found some QA and code issues below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! Some code comments so far
bff8ec7
to
24da8cd
Compare
24da8cd
to
0db42e6
Compare
0db42e6
to
b6d3346
Compare
b6d3346
to
280bdd9
Compare
280bdd9
to
151aa39
Compare
151aa39
to
1a302b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA and code LGTM, tiny non-blocking nitpick on the class naming, good to go as is.
d7ac88a
to
8c4c54c
Compare
Signed-off-by: Nkeiruka <[email protected]>
8c4c54c
to
d85e792
Compare
Done
QA
Screenshots