Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close side panel if panel instance was deleted #1076

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Jan 28, 2025

Done

  • Close side panel if panel instance was deleted

QA

  1. Run the LXD-UI:
  2. Perform the following QA steps:
    • open the side panel on the instance list
    • select the instance that is opened in the side panel
    • bulk delete that instance
    • ensure the side panel closes
    • repeat by opening a different instance and deleting yet another instance, ensure the panel stays open

@webteam-app
Copy link

Copy link
Contributor

@Kxiru Kxiru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks David :)

For onlooker context, here is a screenshot of the old behaviour, which has now been rectified with this PR:
image

@edlerd edlerd merged commit 541dc63 into canonical:main Jan 29, 2025
11 checks passed
@edlerd edlerd deleted the fix-instance-delete branch January 29, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants