Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [WD-18674] CMS Fields - ZFS.Poolname #1080

Merged
merged 1 commit into from
Feb 6, 2025
Merged

feat: [WD-18674] CMS Fields - ZFS.Poolname #1080

merged 1 commit into from
Feb 6, 2025
+106 −16

Conversation

Kxiru
Copy link
Contributor

@Kxiru Kxiru commented Jan 30, 2025 •
edited
Loading

Done

  • Implemented ClusteredZfsNameSelector

QA

  1. Run the LXD-UI:
  2. Perform the following QA steps:
    • [List the steps to QA the new feature(s) or prove that a bug has been resolved]

Screenshots

image
image
image

@Kxiru Kxiru requested review from edlerd and mas-who January 30, 2025 02:49
@Kxiru Kxiru self-assigned this Jan 30, 2025
@webteam-app
Copy link

Demo

Jenkins

demos.haus

@Kxiru Kxiru marked this pull request as ready for review February 3, 2025 15:10
@Kxiru Kxiru force-pushed the cms-fields-zfs-poolname branch from c287eb0 to 23a722f Compare February 3, 2025 15:12
edlerd
edlerd requested changes Feb 3, 2025
View reviewed changes
src/api/storage-pools.tsx Outdated Show resolved Hide resolved
src/pages/storage/forms/StoragePoolForm.tsx Outdated Show resolved Hide resolved
src/components/ConfigurationRow.tsx Outdated Show resolved Hide resolved
src/components/forms/ClusterSpecificInput.tsx Outdated Show resolved Hide resolved
src/pages/storage/forms/ClusteredZfsNameSelector.tsx Outdated Show resolved Hide resolved
src/pages/storage/forms/StoragePoolFormZFS.tsx Outdated Show resolved Hide resolved
@Kxiru Kxiru force-pushed the cms-fields-zfs-poolname branch from 23a722f to c1f3eef Compare February 3, 2025 19:22
@Kxiru Kxiru requested a review from edlerd February 4, 2025 16:07
@Kxiru Kxiru force-pushed the cms-fields-zfs-poolname branch from c1f3eef to cc0cc66 Compare February 4, 2025 16:07
edlerd
edlerd previously approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@edlerd edlerd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA and code LGTM, good work 👍

Tiny nitpick to clean up an unused prop.

src/pages/storage/forms/ClusteredZfsNameSelector.tsx Outdated Show resolved Hide resolved
@Kxiru Kxiru force-pushed the cms-fields-zfs-poolname branch 2 times, most recently from cc90efb to a2b4f7b Compare February 5, 2025 15:47
@Kxiru Kxiru force-pushed the cms-fields-zfs-poolname branch from a2b4f7b to 9699d6c Compare February 5, 2025 17:55
@Kxiru Kxiru requested a review from edlerd February 5, 2025 17:55
edlerd
edlerd approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks for the iterations!

@Kxiru Kxiru merged commit 6c174af into canonical:main Feb 6, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edlerd edlerd edlerd approved these changes

@mas-who mas-who Awaiting requested review from mas-who

Assignees

@Kxiru Kxiru

Labels
Review: Code needed Review: Design needed Review: QA needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kxiru @webteam-app @edlerd