-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow bulk select/delete images in a project and unify pagination placement #620
Conversation
Demo starting at https://lxd-ui-620.demos.haus |
b76a00e
to
fc20256
Compare
I think we should align the page layout between images list and instances list? On the images page, when we bulk select, the delete button appears towards the right hand side of the page where on the instances page, the same action results in the delete button appear where the search bar is located (next to the other actions buttons). Maybe we can align layout and behaviour with the instances page? |
562ca76
to
d8570ed
Compare
8f070e0
to
77cc8f1
Compare
This looks good to me, but I'm still not sure we should move the table pagination to the bottom of the page. For one thing, the reason we moved it to the top was because I observed users being confused and not finding the pagination controls when they were at the bottom, and for another thing, this might interact negatively with the new notifications which float at the bottom of the page. Could we talk about this next week in a working together session? |
77cc8f1
to
b5cc780
Compare
My main idea was to make the pagination placement consistent. In our discussion we concluded, due to users having trouble finding the select notifications if the pagination (with select info) was rendered below, to move all of them up. Now, all Thank you for the fruitful discussion @piperdeck and @mas-who please give it another look as it is now. |
QA looks good, just some code review comments for consideration 🙂 |
b5cc780
to
94d1c91
Compare
LGTM. Thanks for making the changes :) |
When I select an item in the list, the delete button is appearing off to the side for some reason This should be "created at" Since this table's rows will always be at least 2 lines of text tall, maybe this description field should be able to occupy 2 lines before being truncated? Other than that, this is looking good :) |
Signed-off-by: David Edler <[email protected]>
94d1c91
to
6d54846
Compare
Addressed the three issues you found @piperdeck -- please give it another pass. |
Everything looks good! |
Done
PageHeader
componentFixes #618
QA