lxd: Entitlement enrichment for remaining API entities #14880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts` field This will avoid having `access_entitlements: null` in the case we have a response without having asked for `with-access-entitlements=...` in the URL query params. Signed-off-by: Gabriel Mougard <[email protected]>
|
@gabrielmougard as discussed please can you check whether we need to additional slices that convert the pointers back to concrete elements? |
… can have fine-grained permissions - ImageAlias - Server - InstanceBackup - InstanceSnapshot - StorageVolumeBackup - StorageVolumeSnapshot Signed-off-by: Gabriel Mougard <[email protected]>
gabrielmougard
force-pushed
the
fix/missing-entitlements
branch
2 times, most recently
from
535e703 to
9fe0f4d
Compare
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
…pshot Signed-off-by: Gabriel Mougard <[email protected]>
…eVolumeBackup Signed-off-by: Gabriel Mougard <[email protected]>
…ageVolumeSnapshot Signed-off-by: Gabriel Mougard <[email protected]>
…ace entitlement enrichment Signed-off-by: Gabriel Mougard <[email protected]>
…-place entitlement enrichment Signed-off-by: Gabriel Mougard <[email protected]>
…e entitlement enrichment Signed-off-by: Gabriel Mougard <[email protected]>
…titlement enrichment Signed-off-by: Gabriel Mougard <[email protected]>
…n-place entitlement enrichment Signed-off-by: Gabriel Mougard <[email protected]>
…`omitempty` field annotation Signed-off-by: Gabriel Mougard <[email protected]>
gabrielmougard
force-pushed
the
fix/missing-entitlements
branch
from
9fe0f4d to
ce7b04e
Compare
gabrielmougard
changed the title
|
@tomponline Now we should have support for all the entities supported by the OpenFGA permission model. I also ensured that we systematically use slice of pointers in the API handlers during the enrichment. |
tomponline
approved these changes
Jan 31, 2025
|
@gabrielmougard just to confirm, did you test each endpoint is working correctly with-entitlements now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issues discussed here: https://chat.canonical.com/canonical/pl/c3bjkis1g3nmbytao6q5gcaxuc
This also add entitlement enrichment for API entities that weren't added as part as #14748