feat: TLS passthrough #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: the git history is a bit messed up on this, since my branch was originally branched off of my TLS Termination branch |
skatsaounis
requested changes
Sep 5, 2024
skatsaounis
requested changes
Sep 6, 2024
SK1Y101
previously approved these changes
Sep 24, 2024
skatsaounis
requested changes
Oct 3, 2024
| return | ||
| try: | ||
| # just make sure we can open the file | ||
| with open(filepath): |
There was a problem hiding this comment.
and remove lines 78,79. If we decide to leave the checks for cert and key, let's do the same for cacert
There was a problem hiding this comment.
I'm a little confused between this comment and the one above--are we leaving the check or removing it? The purpose behind checking was more to make sure they didn't accidentally pass a private key file as a cert or vice versa, not to fully check that the certificate is actually a valid one. I'm going to leave the check as the suggestion above gives for now.
…es. Set tls config via settings yaml crts directory. Add instructions for TLS termination to README
…, add acl for access to port 80
…fying cert/key files
…it's end. Change agent-service to agent_service to comply with underscore convention
…epath. Let maas-region handle creating the files in the proper place
…pty string instead of None. Make default tls_mode value 'disabled' instead of empty string
… to be installed. Add ssl_cacert variable
…plays valid tls modes based on roles
… in preseed and manifest, and create section for maas-region in preseed/manifest. do not pass CA cert to ha proxy charm variables
wyattrees
force-pushed
the
tls-passthrough
branch
from
f54b48c
to
0886324
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds configuration for passing encrypted requests through HAProxy, to MAAS.
Requires merging of canonical/maas-charms#220. Until it is merged, you can use
latest/edge/passthrough-testfor the maas-region charm channel