Doc: Used fixed IPs for the micro* VMs #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minaelee
requested changes
Dec 12, 2024
|
Sorry it took me so long to get to this one! I think it's a great addition, with the suggested added note to explain why we have them specify the IPs. |
roosterfish
force-pushed
the
fix_range
branch
from
6ab3df1 to
cd4ebb7
Compare
This should help clarify where IP addresses are coming from. Signed-off-by: Julian Pelizäus <[email protected]>
roosterfish
force-pushed
the
fix_range
branch
from
cd4ebb7 to
d1619b0
Compare
|
@minaelee the "Documentation" labeler is working as expected. |
minaelee
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help clarify where IP addresses are coming from.
Fixes #499