Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPE-4255] Fix tests #247

Merged
merged 78 commits into from
May 6, 2024
Merged

[DPE-4255] Fix tests #247

merged 78 commits into from
May 6, 2024

Conversation

MiaAltieri
Copy link
Contributor

@MiaAltieri MiaAltieri commented May 2, 2024 •
edited
Loading

issue

  1. failing metrics tests
  2. failing ha tests
  3. failing rel tests
  4. failing backup tests
  5. failing tls tests

solution

  1. fix issues with pool requests by using sessions
  2. storage re-use test should run first
  • relation tests do not deploy charm correctly
  • checks for new user are pfrone to flakeyness
  1. it is unclear if these ever worked in the first place since they were never enabled on CI - disable these tests until they work
  2. TLS tests don't allow enough time to pass before rotating certs

future Prs

fix backup tests once scope of work is understood

@MiaAltieri MiaAltieri marked this pull request as draft May 2, 2024 14:12
@MiaAltieri MiaAltieri changed the title Fix tests [DPE-4255] Fix tests May 3, 2024
@MiaAltieri MiaAltieri marked this pull request as ready for review May 6, 2024 14:49
Mehdi-Bendriss
Mehdi-Bendriss approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@Mehdi-Bendriss Mehdi-Bendriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

tests/integration/backup_tests/test_backups.py
@@ -72,6 +71,7 @@ async def add_writes_to_db(ops_test: OpsTest):
await clear_writes_action.wait()


@pytest.mark.skip("Skipping tests until fixing backup tests are addressed (DPE-4264).")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tracking it here so we don't forget #249

@Mehdi-Bendriss Mehdi-Bendriss merged commit dd3ceee into 6/edge May 6, 2024
22 of 24 checks passed
@Mehdi-Bendriss Mehdi-Bendriss deleted the fix-tests branch May 6, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mehdi-Bendriss Mehdi-Bendriss Mehdi-Bendriss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MiaAltieri @Mehdi-Bendriss