Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPE-5236][DPE-5647][DPE-5645] update mongo* libs #341

Merged
merged 5 commits into from
Oct 9, 2024
Merged

[DPE-5236][DPE-5647][DPE-5645] update mongo* libs #341

merged 5 commits into from
Oct 9, 2024

Conversation

MiaAltieri
Copy link
Contributor

@MiaAltieri MiaAltieri commented Oct 8, 2024 •
edited
Loading

Issue

  1. mongo* libs need to be updated with latest fixes
  2. tests are failing due to
  • ops deprecation notice getting shown in juju run-action results :/
  • statuses are updated
  • mongos client is not initialised properly

Solution

  1. charmcraft-fetch
  2. update tests for associated issues for a green CI

@MiaAltieri MiaAltieri changed the title charmcraft fetch lib [DPE-5645] update mongo* libs Oct 8, 2024
@MiaAltieri MiaAltieri changed the title [DPE-5645] update mongo* libs [DPE-5647][DPE-5645] update mongo* libs Oct 8, 2024
@MiaAltieri MiaAltieri changed the title [DPE-5647][DPE-5645] update mongo* libs [DPE-5236][DPE-5647][DPE-5645] update mongo* libs Oct 9, 2024
phvalguima
phvalguima approved these changes Oct 9, 2024
View reviewed changes
Copy link

@phvalguima phvalguima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I am missing the context on the lib update, but I believe this is coming from the VM charm instead of being changes in this charm.

@MiaAltieri MiaAltieri merged commit 7d8d0bf into 6/edge Oct 9, 2024
30 of 31 checks passed
@MiaAltieri MiaAltieri deleted the update-mongo-libs branch October 9, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gu1nness Gu1nness Gu1nness approved these changes

@phvalguima phvalguima phvalguima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MiaAltieri @Gu1nness @phvalguima