Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests #110

Merged
merged 5 commits into from
Jul 19, 2023
Merged

Add unit tests #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aadf763
Add unit tests
carlcsaposs-canonical Jul 18, 2023
e20cb40
Re-enable unit tests in CI
carlcsaposs-canonical Jul 18, 2023
f59bb91
Add test_rock_path.py
carlcsaposs-canonical Jul 18, 2023
e6a303e
Pin macaroonbakery to unblock integration tests
carlcsaposs-canonical Jul 18, 2023
11c6f6d
Update comment
carlcsaposs-canonical Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 13 additions & 15 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,19 +27,18 @@ jobs:
- name: Run linters
run: tox run -e lint

# TODO: re-enable after adding unit tests
# unit-test:
# name: Unit tests
# runs-on: ubuntu-latest
# timeout-minutes: 5
# steps:
# - name: Checkout
# uses: actions/checkout@v3
# - name: Install tox
# # TODO: Consider replacing with custom image on self-hosted runner OR pinning version
# run: python3 -m pip install tox
# - name: Run tests
# run: tox run -e unit
unit-test:
name: Unit tests
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
- name: Checkout
uses: actions/checkout@v3
- name: Install tox
# TODO: Consider replacing with custom image on self-hosted runner OR pinning version
run: python3 -m pip install tox
- name: Run tests
run: tox run -e unit

build:
name: Build charms
Expand All @@ -56,8 +55,7 @@ jobs:
name: ${{ matrix.tox-environments }}
needs:
- lint
# TODO: re-enable after adding unit tests
#- unit-test
- unit-test
- build
runs-on: ubuntu-latest
timeout-minutes: 120
Expand Down
Loading