Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pytest_operator_cache plugin instead of conftest.py #114

Merged
merged 8 commits into from
Jul 31, 2023

Conversation

carlcsaposs-canonical
Copy link
Contributor

@carlcsaposs-canonical carlcsaposs-canonical commented Jul 25, 2023

No description provided.

@carlcsaposs-canonical
Copy link
Contributor Author

TODO: switch to v2 after canonical/data-platform-workflows#63 is merged

Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, one question inside.

tox.ini Outdated
deps =
juju==2.9.38.1
; Force compatible mysql-connector-python version <8.1.0: https://github.com/juju/python-libjuju/issues/914
macaroonbakery==1.3.1
pytest
pytest-operator
git+https://github.com/canonical/data-platform-workflows@pytest-plugin-cache\#subdirectory=python/pytest_plugins/pytest_operator_cache
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you planing to publish the plugin on PIP or keep this AS IS?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My plan was to keep as-is since PyPI credentials would add complexity

But do you see value in publishing to PyPI?

@carlcsaposs-canonical carlcsaposs-canonical marked this pull request as ready for review July 28, 2023 11:27
Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like simplifications! Tnx!

Copy link
Collaborator

@paulomach paulomach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@carlcsaposs-canonical carlcsaposs-canonical merged commit 5f58c4d into main Jul 31, 2023
6 checks passed
@carlcsaposs-canonical carlcsaposs-canonical deleted the pytest-plugin-cache branch July 31, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants