-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pytest_operator_cache plugin instead of conftest.py #114
Conversation
TODO: switch to v2 after canonical/data-platform-workflows#63 is merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general, one question inside.
tox.ini
Outdated
deps = | ||
juju==2.9.38.1 | ||
; Force compatible mysql-connector-python version <8.1.0: https://github.com/juju/python-libjuju/issues/914 | ||
macaroonbakery==1.3.1 | ||
pytest | ||
pytest-operator | ||
git+https://github.com/canonical/data-platform-workflows@pytest-plugin-cache\#subdirectory=python/pytest_plugins/pytest_operator_cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you planing to publish the plugin on PIP or keep this AS IS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My plan was to keep as-is since PyPI credentials would add complexity
But do you see value in publishing to PyPI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like simplifications! Tnx!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
No description provided.