Skip to content

Commit

Permalink
hotfix the issue creation in update-libs
Browse files Browse the repository at this point in the history
Currently, the `find` command is looking for the libraries that belong to the charm. I accidentally inverted this expression when addressing some PR comments before merging.

This commit fixes the expression to iterate over all the libraries that DO NOT belong to the charm.
  • Loading branch information
lucabello authored Apr 23, 2024
1 parent 539f545 commit dc288e9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/charm-update-libs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
issue_body=""
# For each library not belonging to the charm, check for a major version update
# "lib" would be of the form `charms.prometheus_k8s.v0.prometheus_scrape`
for lib in $(find "lib/charms/$charm_name" -type f -name "*.py" | sed 's|lib/||' | sed 's/.py//' | sed 's|/|.|g'); do
for lib in $(find "lib/charms/" -type f -name "*.py" | grep -v "$charm_name" | sed 's|lib/||' | sed 's/.py//' | sed 's|/|.|g'); do
# Extract the name of the library, the current major version, and the charm that owns it
lib_name=$(cut -d. -f4 <<< "$lib")
lib_major=$(cut -d. -f3 <<< "$lib")
Expand Down

0 comments on commit dc288e9

Please sign in to comment.