The CLI Client

[zhijie-yang]

• I have signed the CLA?
• I am following the CONTRIBUTING guidelines

Ping the @canonical/rocks team.

---

Description

This pull request implements a cli client for OCI Factory, such that it is no longer required to create pull requests to trigger image builds and releases for the images.

For details see specification RK040.

[cjdcordeiro]

ty for the changes. just a bunch of nits, and over @rebornplusplus approves it we should be good to merge it

[rebornplusplus]

First pass. An overall go-specific review. Please check if the functionality works or not.

Error handling needs to be a bit better in my opinion. In lots of places, we are trying to handle the errors from within the function by printing or panicking, which although would most likely work, is not a nice way to do it and on the rarest of occasions, might just break. Let's change those up to return said errors from the function.

func foo(args Type) (RetType, error) {
	...
	// return errors whenever something does not work
	...
}

...

val, err := foo(bar)
if err != nil {
	// Handle the error here.
	logger.Panicf("foo does not work: %v", err)
}

If, indeed, error-handling within the function is a must, we can do something like this too:

func foo(args Type) (ret RetType, err error) {
	defer func() {
		if err != nil {
			// Handle the error here. Example:
			logger.Panicf(err)
		}
	}()
	...
}

[rebornplusplus]

Just checked the go stuffs -- looks OK to me for a first start. Nice work!

PS. please check whether it works properly or not :) I don't have much context about oci-factory.

[cjdcordeiro]

can u pls ensure all comments are resolved?

[zhijie-yang]

All resolved.

[cjdcordeiro]

Great! Thanks