-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Access Control to Dispatchable Workflows #217
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhijie-yang
force-pushed
the
ROCKS-1340/access-control
branch
from
August 8, 2024 11:18
02fc133
to
3ce593b
Compare
zhijie-yang
force-pushed
the
ROCKS-1340/access-control
branch
from
August 8, 2024 11:31
28c8201
to
35d8bc3
Compare
zhijie-yang
force-pushed
the
ROCKS-1340/access-control
branch
from
August 8, 2024 12:07
ad10e02
to
dc804d1
Compare
zhijie-yang
requested review from
cjdcordeiro and
linostar
and removed request for
cjdcordeiro
August 8, 2024 14:13
clay-lake
requested changes
Aug 9, 2024
2 tasks
cjdcordeiro
reviewed
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(just leaving a comment so I get pinged again when this is ready for review)
zhijie-yang
force-pushed
the
ROCKS-1340/access-control
branch
from
September 10, 2024 15:25
3c3a543
to
df28bae
Compare
This reverts commit f999261.
clay-lake
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for update to the Cancel behavior.
cjdcordeiro
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ping the @canonical/rocks team.
Description
This PR adds the access control to the dispatchable workflow, in order to have the right user access to workflow when external users are granted "write" access.
Related issues
Not Applicable.
Tests
mock-rock/contacts.yaml
as maintainer: Should cancel: runmock-rock/contacts.yaml
as maintainer: Should pass: runLatest workflow run: https://github.com/canonical/oci-factory/actions/runs/10828858187