Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove sosreport installing from oem-qa-checkbox-installer #55

Merged
merged 1 commit into from
Dec 5, 2023
Merged

remove sosreport installing from oem-qa-checkbox-installer #55

merged 1 commit into from
Dec 5, 2023

Conversation

weizhenwu
Copy link
Contributor

sosreport will failed the test snappy/test-snaps-confinement
besides, we have packaged sosreport in bugit, there is no need to install it separately by default

seankingyang
seankingyang approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@seankingyang seankingyang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Agree with you, we should use the bugit.sosreport

hanhsuan
hanhsuan approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@hanhsuan hanhsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weizhenwu weizhenwu merged commit f14f0bd into canonical:main Dec 5, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seankingyang seankingyang seankingyang approved these changes

@hanhsuan hanhsuan hanhsuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weizhenwu @hanhsuan @seankingyang