Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify plainbox config to fit the new suspend_cycles_with_reboot jobs, and set the SANP_TASK_TIMEOUT #58

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Modify plainbox config to fit the new suspend_cycles_with_reboot jobs, and set the SANP_TASK_TIMEOUT #58

merged 2 commits into from
Jan 16, 2024

Conversation

seankingyang
Copy link
Contributor

@seankingyang seankingyang commented Jan 5, 2024 •
edited
Loading

Modify the plainbox.conf for these two purpose:

  • This PR: Retire pm_test from PC suspend 30 cycles and separate IoT suspend cycles (New) checkbox#601 will need the new checkbox config variables
    • STRESS_S3_ITERATIONS : suspend times in each reboot cycles
    • STRESS_SUSPEND_REBOOT_ITERATIONS : total reboot cycles

      Note: Total suspend number = STRESS_S3_ITERATIONS x STRESS_SUSPEND_REBOOT_ITERATION

    • STRESS_S3_SLEEP_DELAY: sleep dealy
    • STRESS_S3_WAIT_DELAY: device check delay
    • STRESS_SUSPEND_SLEEP_THRESHOLD : suspend time threshold
    • STRESS_SUSPEND_RESUME_THRESHOLD: resume time threshold
  • Set the SNAPD_TASK_TIMEOUT to extend the timeout, and make the SANPD test plan in Auto test plan not easy to be timeout by the snap store network not always stable

@seankingyang seankingyang changed the title Modify plainbox config Modify plainbox config to fit the new suspend_cycles_with_reboot jobs, and set the SANP_TASK_TIMEOUT Jan 5, 2024
hanhsuan
hanhsuan requested changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@hanhsuan hanhsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the tests of s3 and s2idle depending on the same variables. It would be great to have comments to let user knows what these variables would impact.

rickwu666666
rickwu666666 approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@rickwu666666 rickwu666666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hanhsuan
hanhsuan approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@hanhsuan hanhsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seankingyang seankingyang merged commit 73625a8 into canonical:main Jan 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickwu666666 rickwu666666 rickwu666666 approved these changes

@hanhsuan hanhsuan hanhsuan approved these changes

@baconYao baconYao Awaiting requested review from baconYao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seankingyang @hanhsuan @rickwu666666