Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(merge): 8.4.1 into main #5056

Merged
merged 11 commits into from
Sep 23, 2024
Merged

chore(merge): 8.4.1 into main #5056

merged 11 commits into from
Sep 23, 2024

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Sep 20, 2024 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Merge 8.4.1 back into main

sergiusens and others added 11 commits September 18, 2024 20:30
@sergiusens
chore: update craft-application to 4.2.2
bb01826 
- Setup the emitter fixture where required
- Make more use of pytest.mark.usefixtures for unused fixtures
- Remove some of the unused fixtures

Signed-off-by: Sergio Schvezov <[email protected]>
@sergiusens
fix: override _run_inner to catch exceptions
9e02eb0 
Remove the heading from the original error to not give the impression
it is a craft application error to the user, but instead an error
generated store side.

Signed-off-by: Sergio Schvezov <[email protected]>
@lengau @sergiusens
build(deps): update craft-application
e25a78b
@mr-cal
build(deps): bump craft-grammar to 2.0.1
0e2cfbf 
Signed-off-by: Callahan Kovacs <[email protected]>
@mr-cal
tests: add tests for coercing numbers
488700a 
Signed-off-by: Callahan Kovacs <[email protected]>
@mr-cal
build(deps): bump craft-store to 3.0.1
758a9ae 
Signed-off-by: Callahan Kovacs <[email protected]>
@mr-cal
build(deps): bump craft-application to 4.2.4
aed3006 
Signed-off-by: Callahan Kovacs <[email protected]>
@mr-cal
fix: catch remote build errors
741e36e 
Signed-off-by: Callahan Kovacs <[email protected]>
@mr-cal
fix: add documentation links to remote build and esm base errors
711ac75 
Signed-off-by: Callahan Kovacs <[email protected]>
@mr-cal
docs(changelog): add 8.4.1 release notes (#5055)
145a790 
Signed-off-by: Callahan Kovacs <[email protected]>
@mr-cal
chore(merge): 8.4.1 into merge/8.4.1
4ab684f
@mr-cal mr-cal requested a review from a team September 21, 2024 01:03
@lengau lengau requested a review from a team September 21, 2024 01:20
dariuszd21
dariuszd21 approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@dariuszd21 dariuszd21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mr-cal mr-cal added the merge label Sep 23, 2024
@mr-cal mr-cal merged commit e402615 into main Sep 23, 2024
9 of 10 checks passed
@mr-cal mr-cal deleted the merge/8.4.1 branch September 23, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariuszd21 dariuszd21 dariuszd21 approved these changes

@lengau lengau lengau approved these changes

Assignees
No one assigned
Labels
merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mr-cal @lengau @dariuszd21 @sergiusens