Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly set PIP_NO_BINARY #5061

Closed
wants to merge 1 commit into from

Conversation

dariuszd21
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I guess :all was silently being ignored by pip?

Looks like the build time has gone from 5 minutes to 20 minutes.

@dariuszd21
Copy link
Contributor Author

Interesting, I guess :all was silently being ignored by pip?

Looks like the build time has gone from 5 minutes to 20 minutes.

I think it was treated as a package name 😅.
Currently the problem is that underlying build is a single-core, and that's why it takes so long to create a package from sources.
And maybe this could fix the RISC-V built 🤔

@mr-cal
Copy link
Collaborator

mr-cal commented Sep 30, 2024

This should start passing once canonical/craft-store#221 is pulled in.

@mr-cal
Copy link
Collaborator

mr-cal commented Oct 4, 2024

Closing because this was cherry-picked in #5084. Thanks!

@mr-cal mr-cal closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants