-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build improvements #240
Build improvements #240
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't reviewed the makefile specifically, because I'm not familiar enough with the syntax, but overall this looks like a really nice set of changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, generally. I have made some comments but they're non-blocking and you may resolve them if you don't feel any action needs to be taken. :)
Currently, the spelling check always rebuilds the documentation, which can take some time for big doc sets. Often we have the documentation build already, so this isn't necessary. Therefore, provide two separate targets, one that does the full check including build and one that only checks the spelling of existing output. Signed-off-by: Ruth Fuchss <[email protected]>
Signed-off-by: Ruth Fuchss <[email protected]>
Signed-off-by: Ruth Fuchss <[email protected]>
Enable parallel processing. Signed-off-by: Ruth Fuchss <[email protected]>
Not all projects use *.rst files. Signed-off-by: Ruth Fuchss <[email protected]>
See canonical#197 If projects include additional Python packages in custom_conf.py, those must be installed before running the build_requirements.py script. This change makes it possible to just specify such packages in the ADDPREREQS variable. Signed-off-by: Ruth Fuchss <[email protected]>
The output of the linkcheck is usually really long. Therefore, print any broken links at the end to make it easier to find them. Signed-off-by: Ruth Fuchss <[email protected]>
Addresses canonical#197 Signed-off-by: Ruth Fuchss <[email protected]>
8e1b32f
to
71a9e69
Compare
Several small improvements to our Makefile targets - see the separate commits.