Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build improvements #240

Merged
merged 8 commits into from
Jun 12, 2024
Merged

Build improvements #240

merged 8 commits into from
Jun 12, 2024

Conversation

ru-fu
Copy link
Contributor

@ru-fu ru-fu commented May 31, 2024

Several small improvements to our Makefile targets - see the separate commits.

Copy link
Contributor

@s-makin s-makin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed the makefile specifically, because I'm not familiar enough with the syntax, but overall this looks like a really nice set of changes.

Copy link
Collaborator

@SecondSkoll SecondSkoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, generally. I have made some comments but they're non-blocking and you may resolve them if you don't feel any action needs to be taken. :)

Makefile.sp Show resolved Hide resolved
Makefile.sp Show resolved Hide resolved
doc-cheat-sheet-myst.md Show resolved Hide resolved
Currently, the spelling check always rebuilds the documentation,
which can take some time for big doc sets.
Often we have the documentation build already, so this isn't
necessary.

Therefore, provide two separate targets, one that does the full
check including build and one that only checks the spelling of
existing output.

Signed-off-by: Ruth Fuchss <[email protected]>
Signed-off-by: Ruth Fuchss <[email protected]>
Enable parallel processing.

Signed-off-by: Ruth Fuchss <[email protected]>
Not all projects use *.rst files.

Signed-off-by: Ruth Fuchss <[email protected]>
See canonical#197
If projects include additional Python packages in custom_conf.py,
those must be installed before running the build_requirements.py
script.
This change makes it possible to just specify such packages in
the ADDPREREQS variable.

Signed-off-by: Ruth Fuchss <[email protected]>
The output of the linkcheck is usually really long. Therefore, print
any broken links at the end to make it easier to find them.

Signed-off-by: Ruth Fuchss <[email protected]>
@ru-fu ru-fu merged commit a2c5c72 into canonical:main Jun 12, 2024
2 checks passed
@ru-fu ru-fu deleted the build-improvements branch June 12, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants