restyle 'Give feedback' button #249
Conversation
There was a problem hiding this comment.
This is brilliant, it works perfectly now. The only device it didn't work on (with the responsive mode) is the Kindle fire, where the button disappears completely - I don't know how many users would be reading on one of those, but on the different phone screens it works beautifully. I'd be happy to approve this with fixing it for Kindle as future work if it's requested... I don't think it's a sizing issue, so it's likely to be a more complicated fix.
There was a problem hiding this comment.
It seems to work okay, so not blocking this from going in - but I still think this should be discussed with UX. Their feedback was that having the button on the page makes more sense.
This is true, but the problem currently with it being on the page is that it forces the documentation header to split over two lines. If we want to keep it on the page, we'll have to find a way to show the page header on the next line (after all the buttons) so that it can be shown on a single line (at least in the desktop view) |
|
I suggest merging this later today and addressing the outstanding aspects of the update subsequently. |
|
As I said, I won't block this - so if you think it's an improvement, get it in. But I think it's kinda misleading to talk about "outstanding aspects" here, since this PR changes the UX and we're leaving the discussion with UX about what the change should be for later. This should have been the first thing to do for this issue. |
|
@ru-fu Hint taken; I'll add it to the liaison meeting agenda. |
|
Shutting this down to make way for a larger page template update. |
With some refactoring, let's address this issue again. Current implementation varies the display style by screen size, preserving older behaviour (floating button) on smaller devices.
This addresses #63.