Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributor listing #250

Merged

Conversation

ru-fu
Copy link
Contributor

@ru-fu ru-fu commented Jun 24, 2024

This PR uses the updated canonical-sphinx-extensions (canonical/canonical-sphinx-extensions#41) and the updated canonical-sphinx package (canonical/canonical-sphinx#25).

@@ -1,2 +1,2 @@
canonical-sphinx
git+https://github.com/canonical/canonical-sphinx@refs/pull/25/merge#egg=canonical-sphinx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that canonical/canonical-sphinx-extensions#41 is merged, do we still want to reference the PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is for canonical/canonical-sphinx#25 - but this has now been merged as well. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it has been merged, but not made it into a release.
While we're developing this, it makes sense to get the latest version on main for the canonical-sphinx extension.
Updated.

Make sure the GitHub folder is also updated when initialising.

Signed-off-by: Ruth Fuchss <[email protected]>
The default is to show contributors, but this can be turned off.

Signed-off-by: Ruth Fuchss <[email protected]>
We should use the latest release in the end - but for now, using
the latest (untagged) version will speed up development.

Signed-off-by: Ruth Fuchss <[email protected]>
@ru-fu ru-fu merged commit 25c5444 into canonical:use-canonical-sphinx-extension Jul 30, 2024
2 checks passed
@ru-fu ru-fu deleted the DOCPR-519-contributors branch July 30, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants