Add tests for the starter pack #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ru-fu
force-pushed
the
DOCPR-649-init-tests
branch
10 times, most recently
from
057a229
to
dbd578b
Compare
ru-fu
force-pushed
the
DOCPR-649-init-tests
branch
7 times, most recently
from
f59484b
to
dc6dc3c
Compare
SecondSkoll
approved these changes
Aug 12, 2024
| @@ -0,0 +1,64 @@ | |||
| name: Test starter pack | |||
There was a problem hiding this comment.
Suggestion: Add a comment to indicate this is intended just for testing the starter pack itself.
I believe a lot of teams clone the starter pack instead of using the init script, so this might help to prevent them from running these checks unnecessarily.
There was a problem hiding this comment.
Makes sense - but if teams keep cloning the starter pack in the future, they will be in a lot of trouble, so we should REALLY tell them not to do this.
Signed-off-by: Ruth Fuchss <[email protected]>
Signed-off-by: Ruth Fuchss <[email protected]>
ru-fu
force-pushed
the
DOCPR-649-init-tests
branch
from
dc6dc3c
to
2a46c1f
Compare
Signed-off-by: Ruth Fuchss <[email protected]>
update to cover the vocab rules
Needed to work around canonical/canonical-sphinx#34 Signed-off-by: Ruth Fuchss <[email protected]>
Add some files that we can use to test the functionality. Signed-off-by: Ruth Fuchss <[email protected]>
ru-fu
force-pushed
the
DOCPR-649-init-tests
branch
from
2a46c1f
to
679b2ed
Compare
|
Expected to fail now since it's pulling the init script from |
ru-fu
merged commit 27312b4
into
canonical:use-canonical-sphinx-extension
2 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a general test for the init script, running it both with "." and with "docs" as installation folder and making sure that both the build and the checks run without errors.
In addition, it adds some test files that we can use to test the starter pack functionality. For now, I've only included related links and Discourse links, mainly to show how these tests can be implemented.