-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds default configuration for PDF generation #264
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested it yet, but overall this looks good!
Some comments about keeping the implementation clean and maintainable.
Adds template for latex_elements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking because we cannot remove the _build
folder (that has our HTML output).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more small comments, but overall, this looks good!
Now the next question is - will RTD pick up this PDF build automatically, or does it need some configuration (probably in .readthedocs.yaml
)?
@ru-fu As long as the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! :)
Curious how the installation of packages works there ... do they have them installed already? Or where do they get them from? |
@ru-fu I imagine they have set build systems with something like Bamboo, rather than ad-hoc or request driven environments. From the lack of xindy support I assume they don't try to dig through configs or anything super clever. |
Adds files required for PDF generation, including some base images, fonts.
Adds make targets to generate PDFs, including a separate target to install local packages.
Provides configuration for the PDF in
custom_conf
.Adds CSS role to allow HTML heading on index without affecting PDF generation due to nesting issue.