Adds project specific excludes to the make entrypoint #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ru-fu
reviewed
Aug 15, 2024
ru-fu
reviewed
Aug 15, 2024
ru-fu
reviewed
Aug 15, 2024
| @@ -1,5 +1,6 @@ | |||
| # This wordlist is from the Sphinx starter pack and should not be | |||
| # modified. Add any custom terms to .custom_wordlist.txt instead. | |||
| # Leave a blank line at the end to support concatenation. | |||
There was a problem hiding this comment.
Maybe add the blank line as well? ;)
There was a problem hiding this comment.
Hmm, it does have one locally... Strange.
There was a problem hiding this comment.
Maybe you have Git configured to cut off blank lines at the end?
ru-fu
reviewed
Aug 15, 2024
Co-authored-by: Ruth Fuchss <[email protected]>
ru-fu
approved these changes
Aug 15, 2024
SecondSkoll
commented
Aug 16, 2024
|
@ru-fu I have indeed tested it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some similar work will need to be done when the vale action is done by GitHub actions, but this works for now. I attempted some more complicated logic, but limitations with make brought me back to this relatively basic approach.