ask for sudo permission for woke and aspell #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the installation was made by-demand, but implications weren't made clear enough. NPM installation is not affected because it's also by-demand but local. This addresses canonical#244.
akcano
added a commit
to akcano/documentation-workflows
that referenced
this pull request
Oct 3, 2024
Done as a counterpart to mandatory installation in spellcheck/spellcheck.py. This fixes the build in canonical/sphinx-docs-starter-pack#291
SecondSkoll
approved these changes
Oct 4, 2024
akcano
merged commit 0a60e50
into
canonical:use-canonical-sphinx-extension
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the installation was made by-demand,
but implications weren't made clear enough.
NPM installation is not affected
because it's also by-demand but local.
This addresses #244.