Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add woke setup to ReadMe #69

Merged
merged 3 commits into from
Aug 8, 2023
Merged

feat: add woke setup to ReadMe #69

merged 3 commits into from
Aug 8, 2023

Conversation

lblythen
Copy link
Contributor

@lblythen lblythen commented Aug 8, 2023

  • Add section to readme.rst, describing inclusive-language setup
  • Add readme.rst to .wokeignore so SP passes make woke
  • Add "subdirectories" to .wordlist.txt so SP passes make spelling
  • Put .wordlist.txt in alphabetical order

- Add section to readme.rst, describing inclusive-language setup
- Add readme.rst to .wokeignore so SP passes ``make woke``
- Add "subdirectories" to .wordlist.txt so SP passes ``make spelling``
.wokeignore Outdated
@@ -2,3 +2,4 @@
# cannot avoid for now, ie
# https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html
doc-cheat-sheet*
readme.rst
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should try to avoid putting a whole file here just for one paragraph. It makes sense to have this for the doc-cheat-sheets since they don't contain actual content, but we want the readme to be checked.
So it would be much better to use this as an example for inline/next-line ignoring.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I'll revert .wokeignore and use next-line as suggested.

readme.rst Outdated
Comment on lines 150 to 153
Suppose a file ``how-to/foo.rst`` includes a URL, that references a ``master``
branch on some site you have no control over. You can't change the URL, and
"master" is non-inclusive language. To exempt ``foo.rst``, add the following
line to ``.wokeignore``:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about splitting this up and explaining how to exclude a file AND how to add an exception within a file?

Exceptions are kinda tricky in RST, unfortunately, because the syntax doesn't really support it ... :(
But for links it's actually easy to do by putting the link at the bottom of the page and putting a comment right above it (see here for an example).
And in the paragraph here it also shouldn't be too hard, because you can just explain how to do it, which will include the required text. ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea - will do.

readme.rst Outdated
Comment on lines 167 to 168
or to check all directories in your project, edit the ``woke`` target in the
``Makefile``. For the command syntax, see the `woke User Guide
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to change .github/workflows/automatic-doc-checks.yml (or maybe we should update that to use the target from the Makefile?).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed it completely - good catch!

- Revert readme.rst out of .wokeignore --- use next-line ignore instead
- Separate ReadMe's woke-config description, into in-file and whole-file
- Add change needed to woke command in automatic-doc-checks.yml
- Add "subtree" to .wordlist.txt
@lblythen lblythen requested a review from ru-fu August 8, 2023 11:25
Copy link
Contributor

@ru-fu ru-fu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ru-fu ru-fu merged commit 4684251 into canonical:main Aug 8, 2023
3 checks passed
@lblythen lblythen deleted the feature/add-woke-setup-to-readme branch August 8, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants