Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oracular/dalmatian support #296

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rodrigogansobarbieri
Copy link
Collaborator

Also fixes charm channels on noble and oracular/dalmatian to use latest/edge.

Closes: #294
Closes: #295

@@ -3,9 +3,15 @@ declare -A RELNAME_MAP=(
[antelope]=2023.1
[bobcat]=2023.2
[caracal]=2024.1
[dalmatian]=latest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dalmatian is 2024.2

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that wouldn't work, the charm channel needs to be latest/edge to to work on noble+

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at present the only way to deploy noble (to get D and E uca) is to use latest/edge charms

CHARM_CHANNEL[mysql-router]=latest/edge
CHARM_CHANNEL[mysql-innodb-cluster]=latest/edge
CHARM_CHANNEL[hacluster]=2.4/edge
CHARM_CHANNEL[ovn-central]=23.09/edge # FIXME: update once caracal released
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to fix these since the correct version is 24.03. I will submit a separate patch.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -0,0 +1,18 @@
# NOTE(ganso): This was copy-pasted from noble
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use a symbolic link rather than copying? then we dont have to update multiple files.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose that eventually the oracular file contents will diverge from noble's? I can update it for now with your changes to noble's

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right but the point is not to have duplicate files so use symlink until they need to diverge

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Also fixes charm channels on noble and oracular/dalmatian to use
latest/edge.

Closes: canonical#294
Closes: canonical#295
common/openstack_release_info Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants