-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add oracular/dalmatian support #296
base: main
Are you sure you want to change the base?
Conversation
@@ -3,9 +3,15 @@ declare -A RELNAME_MAP=( | |||
[antelope]=2023.1 | |||
[bobcat]=2023.2 | |||
[caracal]=2024.1 | |||
[dalmatian]=latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dalmatian is 2024.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that wouldn't work, the charm channel needs to be latest/edge to to work on noble+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at present the only way to deploy noble (to get D and E uca) is to use latest/edge charms
common/ch_channel_map/oracular
Outdated
CHARM_CHANNEL[mysql-router]=latest/edge | ||
CHARM_CHANNEL[mysql-innodb-cluster]=latest/edge | ||
CHARM_CHANNEL[hacluster]=2.4/edge | ||
CHARM_CHANNEL[ovn-central]=23.09/edge # FIXME: update once caracal released |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to fix these since the correct version is 24.03. I will submit a separate patch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
common/ch_channel_map/oracular
Outdated
@@ -0,0 +1,18 @@ | |||
# NOTE(ganso): This was copy-pasted from noble |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe use a symbolic link rather than copying? then we dont have to update multiple files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose that eventually the oracular file contents will diverge from noble's? I can update it for now with your changes to noble's
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right but the point is not to have duplicate files so use symlink until they need to diverge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
457ec11
to
d507aef
Compare
Also fixes charm channels on noble and oracular/dalmatian to use latest/edge. Closes: canonical#294 Closes: canonical#295
d507aef
to
0572c93
Compare
Also fixes charm channels on noble and oracular/dalmatian to use latest/edge.
Closes: #294
Closes: #295