simplify variant handling between client and server #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm actually maybe the real point here is that app.variant and source.variant are different things? Maybe app.variant should be app.client_variant? To indicate the nature of the client that is connected? Argh. |
|
My long-term goal with all of this might be summarized as - if we had a install-sources.yaml where some entries were 'server' and some where 'desktop', would we handle it appropriately? |
Otherwise you end up in this situation where GET /meta/client_variant returns a different value to the variant you'd get from GET /source, and that's just confusing. One way this confusion shows up is that if the default source in the catalog is not server it is not selected, because some slightly confusing client-server interactions end up setting the entry on the source model to one of the synthesized ones. Perhaps these don't need to be two separate attributes, but I think system_setup depends on app.variant so leave that bit for now.
mwhudson
force-pushed
the
no-source-entry-override
branch
from
3cae13e
to
e19adca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.