logging_revamp: add null handler in api endpoint

canonical · Apr 20, 2023 · 2b7a8ef · 2b7a8ef
1 parent da77e20
commit 2b7a8ef
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/uaclient/api/api.py b/uaclient/api/api.py
@@ -1,3 +1,4 @@
+import logging
 from importlib import import_module
 from typing import Callable, List
 
@@ -35,6 +36,9 @@
 def call_api(
     endpoint_path: str, options: List[str], cfg: UAConfig
 ) -> APIResponse:
+    # setup null handler for all API endpoints
+    logging.getLogger("uaclient").addHandler(logging.NullHandler())
+
     if endpoint_path not in VALID_ENDPOINTS:
         return error_out(
             APIError(

diff --git a/uaclient/conftest.py b/uaclient/conftest.py
@@ -135,7 +135,6 @@ def clear_handlers():
 def logging_sandbox():
     # Monkeypatch a replacement root logger, so that our changes to logging
     # configuration don't persist outside of the test
-    # root_logger = logging.RootLogger(logging.WARNING)
     root_logger = logging.getLogger("uaclient")
     root_logger.setLevel(logging.WARNING)